[Addon] Jamba - An assistant for multiboxers. Version 5.4.0 release thread.

[Tehtsuo]

Hey Tehtsuo,

This is awesome. Thanks for adding a bit to Jamba. Great work.

I've taken your changes, tidied the code up a little (changed purple/blue/green to epic/rare/uncommon) and packaged it up in a new release. I've not done as much testing as I would like. One thing I did change that might not be ideal and I would like feedback on is the following. If it turns out to be a bad change, I can revert to the way you had it.

If the character comes finds an item in a loot slot that is not on the watch list, it loots it and leaves any other items alone. I'm a bit worried that this means that corpse the trash was on stops sparkling, which is not what you want. Anyway, could you have a try and see if it works as expected? If its broken I'll fix it.

Cheers,
Jafula.

Your changes look pretty clean, and I like how you encapsulated the loot alerts to trim down the main loot function.

On the loot behavior - it looks like you've trimmed the loot code down to a single pass through the loot window, checking for items in the watch list or that match the filters. The problem with that is if there is a non-watched item above a watched one in the loot window it needs to leave that non-watched item. With only one pass through the loot window it won't know. This is especially a concern since the first slot on most loot windows is gold - with your loop, the first character that loots will get through the loop to the end with safeToLoot set true, and loot the gold. Then any other character will have a good chance of not seeing sparklies on the targeted corpse and you'll have to switch to that character and find a still-sparkling corpse.

My version has two loops through the loot window slots each time through the main loop. The first loop just checks for watched/BoP/BoE/Cloth and if the player is a target for anything it loots it. the second loop picks up everything else, but is skipped if the first loot found anything targeted for another player.

Let me know what you think, and feel free to chat me up if you have questions.

[Jafula]

Ah, my bad. I thought I had broken it. Thanks for the explanation. I'll add your second pass code back in and move the check back out from the inner loop. I'll do that tonight after work and release a new version. I am liking the changes, I'll be using Advanced Loot extensively in WoD.

Your changes look pretty clean, and I like how you encapsulated the loot alerts to trim down the main loot function.

On the loot behavior - it looks like you've trimmed the loot code down to a single pass through the loot window, checking for items in the watch list or that match the filters. The problem with that is if there is a non-watched item above a watched one in the loot window it needs to leave that non-watched item. With only one pass through the loot window it won't know. This is especially a concern since the first slot on most loot windows is gold - with your loop, the first character that loots will get through the loop to the end with safeToLoot set true, and loot the gold. Then any other character will have a good chance of not seeing sparklies on the targeted corpse and you'll have to switch to that character and find a still-sparkling corpse.

My version has two loops through the loot window slots each time through the main loop. The first loop just checks for watched/BoP/BoE/Cloth and if the player is a target for anything it loots it. the second loop picks up everything else, but is skipped if the first loot found anything targeted for another player.

Let me know what you think, and feel free to chat me up if you have questions.

[Jafula]

Tehtsuo, your two pass loot fix is back. I think I put it in properly. Please let me know if it is all good.

Your changes look pretty clean, and I like how you encapsulated the loot alerts to trim down the main loot function.

On the loot behavior - it looks like you've trimmed the loot code down to a single pass through the loot window, checking for items in the watch list or that match the filters. The problem with that is if there is a non-watched item above a watched one in the loot window it needs to leave that non-watched item. With only one pass through the loot window it won't know. This is especially a concern since the first slot on most loot windows is gold - with your loop, the first character that loots will get through the loop to the end with safeToLoot set true, and loot the gold. Then any other character will have a good chance of not seeing sparklies on the targeted corpse and you'll have to switch to that character and find a still-sparkling corpse.

My version has two loops through the loot window slots each time through the main loop. The first loop just checks for watched/BoP/BoE/Cloth and if the player is a target for anything it loots it. the second loop picks up everything else, but is skipped if the first loot found anything targeted for another player.

Let me know what you think, and feel free to chat me up if you have questions.

[Tehtsuo]

Just glanced over it, looks good. Thanks Jafula!