Jamba Map and Quest Log tweaks

[schilm]

Hi all (especially Ebony! ;-) ),

The jamba quest log windows drives me batty every time I open the map/questlog.

So rather than complain, I did something about it... I've attached a new JambaQuest.lua file that contains a right click context menu for sharing/tracking/abandoning quests that looks like the following:

Attachment 1628

Untrack Quest and Abandon Quest work the usual way (JUST on the current toon), Share Quest automatically accepts on toons, per usual.

The additions to the menu are the Jamba UnTrack/Track All Toons and the Jamba Abandon Quest All Toons.

In my testing thus far (somewhat limited) these work fine and I haven't seen any adverse effects elsewhere.


In making this change, I've removed three existing pieces of functionality, but I personally feel the value of this functionality is dubious at best:

1. Abandon All Quests button.

I have never once, in all my years multiboxing, encountered a situation where I WANTED to abandon all my quests... I have accidentally clicked this button (and the associated confirm dialog, as it looks just like the Abandon Single Quest dialog) more than once and have been REALLY irritated because of it...

I just see next to no value in this.

2. Share All Quests button

Somewhat more value here. With the quest specific context menu, and the removal of the irritating window, there isn't a good place for this to live... A button could be added to the questlog to enable this functionality if desired, but I personally don't see the value in adding a lot of extra code to enable this, when you can just share each quest individually... It's sort of nice to have, but not all THAT nice in my opinion.

3. Share/Abandon based on character tags.

I can't possibly envision a scenario where this has any value... It adds a bunch of extra complexity to the code and it just seems utterly pointless... If a toon can accept a quest, why wouldn't you want them to get the quest?

I've commented out the code for the current Quest Log bar as I find it INCREDIBLY irritating. I would REALLY like to see this gone, but if anyone wants it to stay, maybe we could add in a config option that hides it if people don't want to see it?

Generally, I very rarely want to use these Jamba features for quests, so having that bar in your face EVERY time you open the map is just an irritation...

Also, the old window required nearly 500 lines of code and the new mechanism is 162 lines, so it makes things simpler too...


I've attached two files in a zip. JambaQuest.lua contains the changes with the old stuff commented out. JambaQuest-Removed.lua contains the changes and I have deleted the old menu.

Jamba-Quest.zip

[ebony]

Hi all (especially Ebony! ;-) ),

go on am reading

The jamba quest log windows drives me batty every time I open the map/questlog.


So rather than complain, I did something about it... I've attached a new JambaQuest.lua file that contains a right click context menu for sharing/tracking/abandoning quests that looks like the following:

Attachment 1628

Ya i did put sometime ago last year about this very old system that was made for the old quest log. that a right click menu would be fun to try just nerver really got around to do it.

Untrack Quest and Abandon Quest work the usual way (JUST on the current toon), Share Quest automatically accepts on toons, per usual.

The additions to the menu are the Jamba UnTrack/Track All Toons and the Jamba Abandon Quest All Toons.

In my testing thus far (somewhat limited) these work fine and I haven't seen any adverse effects elsewhere.

well i was going to do the same sort of thing or-though i was going to use the same Abandon Quest button and using a mod key to send to all toons.

In making this change, I've removed three existing pieces of functionality, but I personally feel the value of this functionality is dubious at best:

1. Abandon All Quests button.

I have never once, in all my years multiboxing, encountered a situation where I WANTED to abandon all my quests... I have accidentally clicked this button (and the associated confirm dialog, as it looks just like the Abandon Single Quest dialog) more than once and have been REALLY irritated because of it...

I just see next to no value in this.

I use this a LOT! i mean a LOT as well! its so helpful! from login on a team after a few years and just looking at the quest log and meh delete it. i can not say i nerver miss clicked that button in all the years av used it.

Maybe we need more confirm dialog hmmmmmm,

2. Share All Quests button

Somewhat more value here. With the quest specific context menu, and the removal of the irritating window, there isn't a good place for this to live... A button could be added to the questlog to enable this functionality if desired, but I personally don't see the value in adding a lot of extra code to enable this, when you can just share each quest individually... It's sort of nice to have, but not all THAT nice in my opinion.

3. Share/Abandon based on character tags.

I can't possibly envision a scenario where this has any value... It adds a bunch of extra complexity to the code and it just seems utterly pointless... If a toon can accept a quest, why wouldn't you want them to get the quest?

the share all quest button can come in handy if you added a new toon to the group and wonted to sync that new char to the group. why i keep it.

The tag system is well ya i nerver used it. i understand stand whats its for say you only wonted only the class quests on xyz chars but then again its not like you can share it to them chars anyway ya i know this is more of less as useful as a chocolate teapot.

I've commented out the code for the current Quest Log bar as I find it INCREDIBLY irritating. I would REALLY like to see this gone, but if anyone wants it to stay, maybe we could add in a config option that hides it if people don't want to see it?

hmm ya right hmmm right there is a option to turn it off already its always been there. (surly you saw that going though the code!)

Generally, I very rarely want to use these Jamba features for quests, so having that bar in your face EVERY time you open the map is just an irritation...

Also, the old window required nearly 500 lines of code and the new mechanism is 162 lines, so it makes things simpler too...

well yes i did make the bar smaller last year and after i was going to remove it a lot wonted to see it stay, like i said there is something i wonted to do and was thinking a right click menu would be a lot easier so i will try and it and see i might add it in the 4.3 beta release and see what kinda (if) feed back we get on it?

[schilm]

The share all and abandon all are potentially useful, yes, but if there is an alternate means of doing it one by one AND there are a maximum of 25 items you need to Abandon or Share AND it is something you are doing relatively infrequently...

If it were me, I certainly wouldn't want to leave that complexity in the code, that needs to be maintained, to account for such an infrequent activity...

Obviously it's up to you, you're the one maintaining this, but 500 lines of code is a LOT of cruft for a feature such as that...


As to disabling the bar, somehow I never noticed the option for that! So that works for me then.

If you could integrate the changes for the right click menu, that adds back the Track functionality which *I* use and have been missing, and I can now disable the bar so that gets it out of the way, so everyone wins!


One other option I had considered for Share All and Abandon All would be a slash command. It's definitely an infrequent thing to do so, if you did want to consider getting rid of the bar, rather than trying to shoehorn Share All and Abandon All buttons into the questlog where there really isn't a good place for it, a slash command could solve the problem... Just an idea.


Thanks,
Max

[luxlunae]

My problem with Abandon all quests is that it seems to bug out and get stuck because of account wide (pet) quests. I'd like to see those excluded from the feature.

[Dadjitsu]

now the abandon all feature I do use, when I start to out level an area by a few levels I move on and abandon all.

[schilm]

Ok, so I seem to be in the minority not liking the AbandonAll and ShareAll functionality.

So, I went through and implemented that in a new way.

Rather than the large clunky old bar, there is now a small bar with small icon buttons that shows up underneath the quest log in the Quest/Map frame. I just picked four random box icons, easy enough to change to something else if anyone has any better ideas...

This bar is still controlled by the old config option, so it can be hidden if desired.

This new bar has four buttons:

Abandon All

• Works just like it used to. It loops through all of your toons and abandons all the quests on each toon.
• NOW ignores quests that cannot be abandoned, such as the Account Wide quests Luxlunae mentioned.

Share All

• Used to just loop through the current toons quests and just shared those, NOW loops through all toons and attempts to share all quests from all toons.

Track All

• Back from the abyss!!!
• Used to just loop through the current toons quests and just tracked those, NOW loops through all toons and attempts to track all quests from all toons.

Untrack All

• Back from the abyss!!!
• Used to just loop through the current toons quests and just untracked those, NOW loops through all toons and attempts to untracks all quests from all toons.

I have removed the old bar from the code as the only difference now is the tag functionality which cluttered things up and I just can't see value there.

Jamba-Quest_2016_04_02.zip

[luxlunae]

Yeah, I definitely like it because I'll quest a toon for a while, then they may end up on a team for another 30 levels and then I've got quest clutter that needs abandon all. Or just moving on from a zone if I'm doing quest leveling I like a nice clean slate. I'll try out your extension schilm. And thanks again, for maintaining the addon ebony!

[schilm]

Yeah, I definitely like it because I'll quest a toon for a while, then they may end up on a team for another 30 levels and then I've got quest clutter that needs abandon all. Or just moving on from a zone if I'm doing quest leveling I like a nice clean slate. I'll try out your extension schilm. And thanks again, for maintaining the addon ebony!

Yea, when I started thinking about it, I can see the draw of it... I've never personally used the "All" buttons, but I've never really had all that many teams. I guess I just hated the old UI so much it clouded my thinking! ;-)

Anyway, let me know if the abandon functionality works as you would like with the account wide quests (seems to skip the garrison pet quest for me).

Thanks,
Max

[ebony]

getting

1x [ADDON_ACTION_BLOCKED] AddOn 'Jamba-Quest' tried to call the protected function 'CompactRaidFrame14:Show()'.!BugGrabber\BugGrabber .lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\CompactUnitFrame.lua:290: in function `CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:248: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:100: in function <FrameXML\CompactUnitFrame.lua:47>


Locals:

[schilm]

Do you have a full error stack? or error line? Where do you get the error? On load? On questlog open?

The string "raidframe" does not exist in the updated addon... so without some more context, I don't know how it could be calling "CompactRaidFrame14:Show()"