[Classic] Good farming team?

[Apatheist]

Hunters for PvE can actually quite be pretty solid. An owl with screech provides spamable AE threat and traps are the only long duration CC that works on any mob type. Problem is the dead zone is a pain for PvP and you have no way outside of trinkets to remove AE fears.

Shadow priests run out of mana very fast, have no AE damage spells (unless you take holy nova which is extremely expensive to cast) and are very squishy despite the 15% reduced physical damage from shadow form. Vampiric embrace has a 10 second cooldown so you can only generally cast it on 1-2 targets most fights and if you're focusing damage on that target enough to produce significant healing, it's going to die first leaving you without healing. It works reasonably well on single target fights but for AE grinding or dungeon trash it's pretty slow.

Warlocks are better in every way IMO. If you're willing to forgo the convenience of a mage for portals and free water a healer +4 warlocks will be one of the stronger all-round PvE/PvP teams for many reasons.