Jamba Map and Quest Log tweaks

[schilm]

One other thing to try:

The code I was using added the dropdown buttons as follows:

UIDropDownMenu_AddButton(info, UIDROPDOWNMENU_MENU_LEVEL);

but level is an optional parameter and we aren't concerned with level here. So I just changed to this:

UIDropDownMenu_AddButton(info);

and it works fine for me

Try that and see if it makes a difference for you?

Thanks,
Max

[ebony]

Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y?

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half using the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max

Attachment 1632

sounds like the way it should be done the problem i found and read is with taint-y? is it could be some other addon (even blizzards) own code that when jamba-quest is using it after is making the problems. but its so random and does so many random things for sure something is not right. ill test this and see if i can found anything wrong all being well sounds like it should not be as taint-y, we don't want taint errors

Thanks for the hard work on the module.

Oh i don't like the icons am getting trying to get someone to make some nice new ones for us

[schilm]

I despise the icons as well!

The bags are dumb, but I couldn't find any existing icons that made any sense whatsoever, so... I picked bags. 'cause there were four of them. And I needed four buttons.



It's still possible we'll need to replace the dropdown code with some alternative approach, but the new code is definitely better. (FYI, the zip file does NOT contain the removal of the UIDROPDOWNMENU_MENU_LEVEL parameters, you'll need to delete those yourself.)

[ebony]

JambaQuest.zip

Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y?

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half usign the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max

ok i think i found the few problems there was should be taint free now.


if u wonted to see what i done. ill get this added to 4.3 Beta release for more testing soonish

JambaQuest.zip