If you plan on world PvP and doing a really good job (or even 5v5 arena) -- try and stay away from one button macros
WoW is pretty simple now, we only need like 6 buttons, unlike the old days where we needed 4250238712 keybinded spells.