At the start of EVERY expansion since BC JC has been the most profitable profession. It is slowly over taken by Alchemy. Skinning is another VERY profitable profession.

I have a JC, Skinner, and a Herbalist. I make around 500k at the start of every expansion selling gems, leather and herbs. I have 5 alchey's who make me money after everyone levels their proffesions to max.