Are you talking about Quality settings in the game? Or Resolution?

I had a similar problem with resolution, I would set it in wow reload and it would be back at the previous setting. Was maximizer settings i had to adjust and not wow settings.

Quality settings should stay set if you exit the game properly, might not save the settings if you just close the window without exiting correctly.