Jamba Map and Quest Log tweaks

[ebony]

Do you have a full error stack? or error line? Where do you get the error? On load? On questlog open?

The string "raidframe" does not exist in the updated addon... so without some more context, I don't know how it could be calling "CompactRaidFrame14:Show()"

ya don't know why its calling it but its calling it when i enter a bg.

[schilm]

I just entered Ashran and got that error from SpartanUI:

1x [ADDON_ACTION_BLOCKED] AddOn 'SpartanUI_Artwork' tried to call the protected function 'CompactRaidFrame13:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\CompactUnitFrame.lua:290: in function `CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:248: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:100: in function <FrameXML\CompactUnitFrame.lua:47>


Locals:

Don't get it related to Jamba-Quest though...

[ebony]

after a little reading its called taint

"Basically, some addons that - for example - don't have certain variables localized correctly will taint secure functions."

here some posts.

http://us.battle.net/wow/en/forum/topic/6607331970
http://us.battle.net/wow/en/forum/topic/8569857326#5

[schilm]

I can only assume this has something to do with replacing the default right click menu on the quest log, but I've tried and frankly can't find any other means of doing it. In fact MANY other addons have nearly the exact same code for dropdown menus that I employed here... There was a "NoTaint_DropdownMenu" addon someone released years ago, but it doesn't seem to have been maintained in many years. I tried it, but I couldn't get it to function.

All that said I haven't encountered a single problem related to this error. All seems to work perfectly fine in Jamba and everywhere else in my testing...

I installed BugGrabber and played for many hours. I have a slew of addons so while I haven't seen this particular error from Jamba Quest pop up, I get a boatload of this type of error from various addons going into and out of battlegrounds, joining raids, etc...

I haven't seen any errors or problems with this or any odd behavior anywhere else in the game. Has this caused any issue for you?

[ebony]

I can only assume this has something to do with replacing the default right click menu on the quest log, but I've tried and frankly can't find any other means of doing it. In fact MANY other addons have nearly the exact same code for dropdown menus that I employed here... There was a "NoTaint_DropdownMenu" addon someone released years ago, but it doesn't seem to have been maintained in many years. I tried it, but I couldn't get it to function.

All that said I haven't encountered a single problem related to this error. All seems to work perfectly fine in Jamba and everywhere else in my testing...

I installed BugGrabber and played for many hours. I have a slew of addons so while I haven't seen this particular error from Jamba Quest pop up, I get a boatload of this type of error from various addons going into and out of battlegrounds, joining raids, etc...

I haven't seen any errors or problems with this or any odd behavior anywhere else in the game. Has this caused any issue for you?

there was a few problems i saw with blizzard raid frames not updating right if new players came in.

Still i don't like lua errors and the bug reports am going to keep getting will do my head in. so unless i can find a way to fix it will not make the mainline release or though a lot of the code is still helpful the new frame is a lot better then the old one.
But with the DropdownMenu and the errors and problems that will prob get removed and they have to be be buttons on the frame. let me know what you think??

[schilm]

From what I have seen in game, I only see *anything* related to this type of "taint" error with bug grabber installed. I've noticed no issues anywhere else in the UI. Something is definitely happening in the background that is slightly wonky, but I haven't seen any explicit breaking problems from it anywhere. And frankly, I haven't even seen the BugGrabber error related to Jamba-Quest at all, just related to other various addons I use.

As far as pulling the old code, and just using the bar without the context menu, I don't think that will work as you'll then lose the ability to select and abandon /track/untrack a single quest (share would still work correctly I believe though)

While the old code is somewhat kludgey with the mechanisms for selecting a quest in the questlog, without the context menu, its kind of necessary and you're losing functionality if you remove it.

As a software developer for many years, I've come to the opinion that you can never eliminate this type of "warning" from your code and you'll go mad trying... So unless there were explicit breaking issues, I'd personally run with it... but that said, it's your addon and I (and many others) greatly appreciate the work you've done on it, so if you're not comfortable with the errors then that's what it is.

I'll look around and see if I can find a different means of generating the right click context menu, but being that I haven't even see the Bug Grabber error related to Jamba-Quest and there aren't any other explicit issues to be looking for, I'm not sure how much success I'll have...

[ebony]

From what I have seen in game, I only see *anything* related to this type of "taint" error with bug grabber installed. I've noticed no issues anywhere else in the UI. Something is definitely happening in the background that is slightly wonky, but I haven't seen any explicit breaking problems from it anywhere. And frankly, I haven't even seen the BugGrabber error related to Jamba-Quest at all, just related to other various addons I use.

As far as pulling the old code, and just using the bar without the context menu, I don't think that will work as you'll then lose the ability to select and abandon /track/untrack a single quest (share would still work correctly I believe though)

While the old code is somewhat kludgey with the mechanisms for selecting a quest in the questlog, without the context menu, its kind of necessary and you're losing functionality if you remove it.

As a software developer for many years, I've come to the opinion that you can never eliminate this type of "warning" from your code and you'll go mad trying... So unless there were explicit breaking issues, I'd personally run with it... but that said, it's your addon and I (and many others) greatly appreciate the work you've done on it, so if you're not comfortable with the errors then that's what it is.

I'll look around and see if I can find a different means of generating the right click context menu, but being that I haven't even see the Bug Grabber error related to Jamba-Quest and there aren't any other explicit issues to be looking for, I'm not sure how much success I'll have...

right but i uninstalled bug grabber and it still does it, it block lots of blizzard UI buttons/menus - so they don't work try leaving a que and nothing happens errors change from time to time what loads up 1st.

the only i can think of is doing like the other mutiboxing addons that just uses the blizzard button and just sends the msg to remove them on the clones when that is called.


but i already had few friends test this and are having the same problem as me, but thanks for the help if players would like to use this then they can but ill see what happens if anything to get added. am not sure if its a EU/US thing? if your saying you seeing no problems at all.


Edit:: I think i found the bug:

table.insert(UISpecialFrames, yourframehere)

using this code seems to fix a lot of the errors i was getting one was if a StaticPopupDialogs that was made by isboxer (wrong char in wrong slot) and then jamba-quest was trying to over right braking all blizzard StaticPopupDialogs.

anyway ill test it with this code and see if i see anymore errors

http://www.wowinterface.com/forums/s...ad.php?t=41455

[schilm]

OK, so you ARE seeing some real problems that you think are attributed to this? You had only said there seemed to some issues with the raid frames updating, which didn't seem like a critical problem...


I'll test some more this evening once the servers come back up from maintenance , but no, I have not seen any problems whatsoever. I've entered bgs, left bg queues, left bgs, entered dungeons, left dungeon queues, left dungeons, converted group to raid, converted back to group... nothing.


Can you be more explicit with a solid bug report detailing exactly what you are seeing and explicit steps you take for it to happen?

Also, which other addons do you use?

Thanks,
Max

[ebony]

OK, so you ARE seeing some real problems that you think are attributed to this? You had only said there seemed to some issues with the raid frames updating, which didn't seem like a critical problem...


I'll test some more this evening once the servers come back up from maintenance , but no, I have not seen any problems whatsoever. I've entered bgs, left bg queues, left bgs, entered dungeons, left dungeon queues, left dungeons, converted group to raid, converted back to group... nothing.


Can you be more explicit with a solid bug report detailing exactly what you are seeing and explicit steps you take for it to happen?

Also, which other addons do you use?

Thanks,
Max

well am not sure its just this doing it but if i go back to the old Jamba_quest it does not do it.

Its defo taint. the way i found it causing if if you get the isboxer StaticPopupDialogs to show and then (jamba_quest Or though that what it says) starts the blocking the UI. so i would think its StaticPopupDialogs that is taint

My changes have fixed the RaidFrames problams its just the the superLocked down BG button.

1x [ADDON_ACTION_FORBIDDEN] AddOn 'Jamba-Quest' tried to call the protected function 'JoinBattlefield()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `JoinBattlefield'
Blizzard_PVPUI\Blizzard_PVPUI-1.0.lua:524: in function `HonorFrame_Queue'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>


Locals:
nil

Tainit.log

4/12 18:09:43.397  Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:518 HonorFrame_Queue()
4/12 18:09:43.397  An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:09:43.397      Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:524 HonorFrame_Queue()
4/12 18:09:43.397      HonorFrameSoloQueueButton:OnClick()
4/12 18:10:07.359  Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:518 HonorFrame_Queue()
4/12 18:10:07.359  An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:10:07.359      Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:524 HonorFrame_Queue()
4/12 18:10:07.359      HonorFrameSoloQueueButton:OnClick()
4/12 18:10:09.272  Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:518 HonorFrame_Queue()
4/12 18:10:09.272  An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:10:09.272      Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua:524 HonorFrame_Queue()
4/12 18:10:09.272      HonorFrameSoloQueueButton:OnClick()

More detailed log

4/12 18:15:27.616      LoadAddOn()
4/12 18:15:27.616      Interface\FrameXML\UIParent.lua:343 UIParentLoadAddOn()
4/12 18:15:27.616      Interface\FrameXML\UIParent.lua:422 TimeManager_LoadUI()
4/12 18:15:27.616      Interface\FrameXML\UIParent.lua:923
4/12 18:15:27.616  Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:27.616      Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()
4/12 18:15:27.616      Interface\AddOns\Jamba-Quest\JambaQuest.lua:1797 initFunction()
4/12 18:15:27.616      Interface\FrameXML\UIDropDownMenu.lua:69 UIDropDownMenu_Initialize()
4/12 18:15:27.616      Interface\AddOns\Jamba-Quest\JambaQuest.lua:192
4/12 18:15:27.616      xpcall()
4/12 18:15:27.616      safecall Dispatcher[1]:9

-----------------------------------------------------------------------------------

4/12 18:15:28.285  Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:28.285      Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:478 initFunction()
4/12 18:15:28.285      Interface\FrameXML\UIDropDownMenu.lua:69 UIDropDownMenu_Initialize()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:462 CompactUnitFrameProfilesGeneralOptionsFrameSortByDropdown:updateFunc()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:184 CompactUnitFrameProfiles_UpdateCurrentPanel()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:171 CompactUnitFrameProfiles_ActivateRaidProfile()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:45 CompactUnitFrameProfiles_ValidateProfilesLoaded()
4/12 18:15:28.285      Interface\AddOns\Blizzard_CUFProfiles\Blizzard_CompactUnitFrameProfiles.lua:25
4/12 18:15:28.285  Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:28.285      Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()

You can find me in the live irc chat if you want to talk to me about it.



Edit2:::

http://us.battle.net/wow/en/forum/topic/15007380994

seem to be the problem(bug) i have found that is couseing this problam

[schilm]

Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y?

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half usign the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max

JambaQuest_2016_04_12.zip