Sweet, I was in no way running it down, simply giving you some feedback. Keep up the good work, I for one will be using this add-on :)
Printable View
Sweet, I was in no way running it down, simply giving you some feedback. Keep up the good work, I for one will be using this add-on :)
if you modify silentwhisper.lua, changing the whisper function to the following
this should allow boxers who use partyleader or focus to use the addon.Code:function Whisper(Message, sender)
if !isPartyLeader then
local rname
local leader = "party"..GetPartyLeaderIndex()
inInstance, instanceType = IsInInstance()
local msg = "Sent by "..sender..": "..Message
if mbLeader == "party" then
if instanceType == "pvp" then
rname = GetUnitName("focus", false)
else
rname = GetUnitName(leader, false)
end
elseif mbLeader == "focus" then
rname = GetUnitName("focus", false)
else
rname = nameLeader
end
SendChatMessage(msg , "WHISPER", "Common", rname);
end
end
add a line near the beginning declaring nameLeader = the named character of the leader if required.
NOTE: for people using partyleader, this takes battlegrounds into consideration and will use focus for leader definition instead.
It also checks to see if the character is leader and only resending whispers.
And it will send the originator of the message
nice addition to the code Djarid :)
I've updated v0.1.0 to v0.1.1
This includes one of the requested features - original sender name on redirected whisper!
If you want me to add anything else fire away with ideas :)
Nice one guys, truly a very good mod (well I am just installing the new one but if works like you say magic) no longer do I have to tell everyone in Guild that I am on so and so as the main, they can whisper who they like and I won't be ignoring them as I have no sound on the other machines to keep the speed up.
I simply can't wait to test this Addon at home (on work right now :( ) - thanks Falkor and the others for your work!
It was awesome how many whispers I got which I never read because I simply didn't see them and then pressing "R" for reply whisper by accident made a receiver visible, every time on every character - scary stuff. :D
I will be expanding on this addon more and more :)
Possible ideas:
- Include a wow interface to change your main name.
- Allow you to customise the whisper format
- Include timestamps with whispers
doesn't the toolbox mod do this already? JW cuz I use that one.
FFS people, it's AN ADD ON.
Every single addon you install comes as a .ZIP or a .RAR, it's not like this guys pawning a .EXE to do this...
Sure, the guys new, but if you don't trust him don't rail him about it...
I took a 30 second look at this (and read every single line of included code) and there is nothing malicious about it... other than the fact this guys trying to contribute tot he community by giving something back to it.
One feature that would be handy is to have the main player receive the chat and update his /reply queue... I'm not certain that code is exposed however.... a cursory glance at wowwiki doesn't show anything obvious but you could probably crack the default chatframe code open and find it.Quote:
Originally Posted by 'Falkor',index.php?page=Thread&postID=41411#post41 411
Sorry to say but were limited to functions that blizzard provide within their LUA framework, and the features that would make it possible to update the reply queue are protected functions, meaning we cannot edit the reply queue in any way :(
I understand why they have done this and that is because it could be used to spoof whispers from unknown users!