Tanking macro for warriors

So I have a 3 box team atm, warrior, druid, rogue... so I have the option to have a tank and healer... Now i tried it once but I couldnt figure out the right macro for the warrior in order to hold AoE aggro the best... So I figure I will toss a macro here for critique before i go and respec back to prot to try again. Basically Ive got my rogue and warrior on one button for the abilities... it works very nice for when they ae all DPS... anyhow, let me know if you guys think this would be the best way to go for the warrior.

/castsequence reset=6 thunder clap, devastate, devastate, devastate, devastate, devastate, devastate
/castrandom revenge, shield slam, shockwave

I have the other buttons set to the various heals that I need to do to either just the tank or to the group.

Would that work for the warrior? or does anyone have any better solutions?

edit: added shockwave to /castrandom

http://www.wowwiki.com/Useful_macros_for_warriors

There is a nice mouseover tanking macro in that lot, that will stick a sunder/devastate on a mob under your cursor (no need to change target). Don't forget shockwave if you are prot specced. It's imba.

I have no idea about your current macro ... seems ok.

ya i read that one, I wasnt completely sure as to how it worked though, but it looked handy... I think though since the huge increase to threat generation in defensive stance that thunder clap would be enough nowadays, that and of course shockwave.

Forgive me if this is a dumb comment. I know more about tanking than macros, but in the second part of your macro you might wanna add revenge and shockwave to build more aggro

aye, revenge is there, i just missed shockwave when I was writing it out the first time.

Well for me personally just laying down TC on every cd is enough to keep AoE aggro. Then I just Shield slam the main target every cd, revenge every cd, and devestate when they aren't up.