Log in

View Full Version : [HowTo] Change SCTD to show party damage as well.



The IT Monkey
04-03-2008, 06:25 PM
Hey All,
Did a bit of research today and noticed that SCTD has been updated for 2.4. So I did a little more digging and found what has to be changed to show the entire parties damage.

In the sctd.lua line 50 reads like this:

local COMBATLOG_FILTER_MINE = COMBATLOG_FILTER_MINE

Change it to read like this:

local COMBATLOG_FILTER_MINE = bit.bor (
COMBATLOG_OBJECT_AFFILIATION_PARTY,
COMBATLOG_OBJECT_AFFILIATION_MINE,
COMBATLOG_OBJECT_REACTION_FRIENDLY,
COMBATLOG_OBJECT_CONTROL_PLAYER,
COMBATLOG_OBJECT_TYPE_PLAYER,
COMBATLOG_OBJECT_TYPE_OBJECT
);

COMBATLOG_FILTER_MINE is a WoW filter that usually only calls:
COMBATLOG_OBJECT_AFFILIATION_MINE,
COMBATLOG_OBJECT_REACTION_FRIENDLY,
COMBATLOG_OBJECT_CONTROL_PLAYER,
COMBATLOG_OBJECT_TYPE_PLAYER,
COMBATLOG_OBJECT_TYPE_OBJECT
I simply added
COMBATLOG_OBJECT_AFFILIATION_PARTY,
to the mix and it all went well.

I first tried just changing MINE to FRIENDLY_UNIT... but that was a DISASTER.

Hope you all enjoy.

-J (the IT Monkey)

Edit: Almost forgot... you can download SCTD here ('http://www.wowinterface.com/downloads/dl.php?id=4913') . <--Original file... not modified.

Tdog
04-04-2008, 12:33 AM
I'm a complete noob when it comes to lua. Could you tell me what's the exact name of the folder I'm looking in to change this?

Ughmahedhurtz
04-04-2008, 12:49 AM
\World of Warcraft\Interface\Addons\SCTD\....

I seriously hope they fix parrot. The "throttling" feature where it combines all damage from a single skill type within a certain time window was AWESOME. Seeing a damage scroll that said "5293 - Fireball (2 hits, 2 crits)" was just too damned nifty.

Djarid
04-04-2008, 03:37 AM
Nice one IT Monkey - I will try and add an SCT page to the wiki and have this mentioned

Maxion
04-04-2008, 01:10 PM
Nice, I got the mod and changed the lua, have yet to see the mod in game though. Whats the / command to set it up? /sct or/sctd didn't work for me.

The IT Monkey
04-04-2008, 02:33 PM
Are you sure you have the mods enabled? /sct should get you at the very least a help message. /sct menu should show you a message.

@Ang@
04-04-2008, 02:44 PM
BTW u need to install SCT too, dl here http://www.wowinterface.com/downloads/info3965.html because SCTD is a "plug in", check on your add on list on character page if u missing something (like me :P )

I do the change in .lua and it work great for me, thanks for this :)

The IT Monkey
04-04-2008, 03:12 PM
I do the change in .lua and it work great for me, thanks for this :)

Not a problem.. it was my pleasure. I looked at MSBT today as it has been partially updated for 2.4. It is supposed to do the throttling thing like parrot. I dug around in it for a couple hours but no matter what I did to it I couldn't get it to register party events. It will take someone a little more deft in hacking lua than me to get it to work.

Maxion
04-05-2008, 02:11 PM
BTW u need to install SCT too, dl here http://www.wowinterface.com/downloads/info3965.html because SCTD is a "plug in", check on your add on list on character page if u missing something (like me :P )

I do the change in .lua and it work great for me, thanks for this :)That should do it, hehe, thanks :)

cepheus
04-05-2008, 03:16 PM
Thanks for this tip. Worked right away for me :D

But I have one problem if there is someone that could help me. My warlocks is SL specced, and when they get hit, the damage transfered to the pet is registered, and this gets *very* spammy. Anyone know is there is someway to ignore the damage mitigated through Soul Link?

Anozireth
04-05-2008, 09:29 PM
I just gave this a shot and it worked first try for me too, thanks for the tip! :D

FunkStar
04-06-2008, 06:40 AM
Is there any way that a lua programmer can make extra frames for these?

My idea is to have my Unit frames lined up like this:

Party1 --- Party2 --- Party3 --- Party4 --- Party5

so if there would be 5 extra frames u could scroll them below it like this:

Party1 --- Party2 --- Party3 --- Party4 --- Party5

p1dmg ----- p2dmg ---- p3dmg ---- p4dmg ---- p5dmg
p1dmg ----- p2dmg ---- p3dmg ---- p4dmg ---- p5dmg

I hope it makes sense :p

Ughmahedhurtz
04-06-2008, 07:13 PM
I spent a fair amount of time last night and today poking at MSBT and the beta Parrot code and I just can't figure out how they restrict damage to self/pet only. /grumble

I have some queries into the mod authors so we'll see if I get any response.

Silly Gooooose
04-06-2008, 08:42 PM
this is awsome except it also shows other people besides my shaman, when in pvp.

Wish there was a way to tell it who to show, and who not to show.

I found a bit of a work around for BG (WSG and AB anyway, haven't tested the others.)

It seems that when I que for group WSG or AB, It gives me leader every time (what ever char is lead of my party, gets lead in the BG) so I can just move myself and my 4 alts to a new party.

The IT Monkey
04-07-2008, 01:38 PM
this is awsome except it also shows other people besides my shaman, when in pvp.

Wish there was a way to tell it who to show, and who not to show.

I found a bit of a work around for BG (WSG and AB anyway, haven't tested the others.)

It seems that when I que for group WSG or AB, It gives me leader every time (what ever char is lead of my party, gets lead in the BG) so I can just move myself and my 4 alts to a new party.It doesn't distinguish between your alts and other players... the modification only says "include damage being done by my party as my own"... if you get put in a BG that your toons are not all in your party and you don't want to see other peoples damage as your own I would suggest turning the mod off. SCTD and SCT are only "fun" mods... I don't consider them as "vital" to the multiboxing experience. It is nice to know when you are going up against a mob and they are resisting something one of your toons is shooting... other than that it is just pretty to see all the damage you are doing. ;)

firest4rter
04-07-2008, 10:34 PM
Just made this mod to my SCTD and it works perfectly. Not a totally esential mod, however I do like seeing those crits and big numbers. Thanks for your work to make this happen.

Spekio
04-12-2008, 11:50 PM
I just tried the change and I'm loving it. The only problem is I don't see the party's pet damage. Any idea on what I can replace the pet damage line with to get the damage from all the pets in my party?

Los
04-16-2008, 06:13 AM
think we need to dig in this function a bit, not familliar with those new events yet, but it would be very fun to add names in front of the dmg lines (at least i would like it myself)

-- Parses all combat events using combat log events


function SCTD:ParseCombat(arg1, timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)

--custom search first
--if (db["SCTD_CUSTOMEVENTS"] and SCT:CustomEventSearch(arg1) == true) then
--return
--end

if not COMBAT_EVENTS[event] then return end

local toPlayer, fromPlayer, toPet, fromPet
if (sourceName and not CombatLog_Object_IsA(sourceFlags, COMBATLOG_OBJECT_NONE) ) then
fromPlayer = CombatLog_Object_IsA(sourceFlags, COMBATLOG_FILTER_MINE)
fromPet = CombatLog_Object_IsA(sourceFlags, COMBATLOG_FILTER_MY_PET)
end

--if not from player or pet, then end
if not fromPlayer and not fromPet then return end

local healtot, healamt, parent
local amount, school, resisted, blocked, absorbed, critical, glancing, crushing
local spellId, spellName, spellSchool, missType, powerType, extraAmount, environmentalType, extraSpellId, extraSpellName, extraSpellSchool
local text, texture, message, inout, color

------------damage----------------
if event == "SWING_DAMAGE" or event == "RANGE_DAMAGE" or event == "SPELL_DAMAGE" or event == "SPELL_PERIODIC_DAMAGE" or event == "DAMAGE_SHIELD" or event == "DAMAGE_SPLIT" then
if event == "SWING_DAMAGE" then
amount, school, resisted, blocked, absorbed, critical, glancing, crushing = select(1, ...)
else
spellId, spellName, spellSchool, amount, school, resisted, blocked, absorbed, critical, glancing, crushing = select(1, ...)
texture = select(3, GetSpellInfo(spellId))
end
text = tostring(amount)

if (amount < db["SCTD_DMGFILTER"]) then return end
if (crushing and db["SHOWGLANCE"]) then text = SCT.LOCALS.Crushchar..text..SCT.LOCALS.Crushchar end
if (glancing and db["SHOWGLANCE"]) then text = SCT.LOCALS.Glancechar..text..SCT.LOCALS.Glancechar end
if (blocked) then text = string_format("%s (%d)", text, blocked) end
if (absorbed) then text = string_format("%s (%d)", text, absorbed) end
if (event == "SWING_DAMAGE" or event == "RANGE_DAMAGE") and school == SCHOOL_MASK_PHYSICAL then
if fromPlayer then
self:DisplayText("SCTD_SHOWMELEE", text, critical, nil, nil, destName)
elseif fromPet then
self:DisplayText("SCTD_SHOWPET", text, critical, SCHOOL_STRINGS[school], resisted, destName, PET)
end
else
local etype
if fromPet then
etype = "SCTD_SHOWPET"
elseif event == "SPELL_PERIODIC_DAMAGE" then
etype = "SCTD_SHOWPERIODIC"
elseif event == "DAMAGE_SHIELD" then
etype = "SCTD_SHOWDMGSHIELD"
else
etype = "SCTD_SHOWSPELL"
end
self:DisplayText(etype, text, critical, SCHOOL_STRINGS[school], resisted, destName, spellName, texture)
end

------------misses----------------
elseif event == "SWING_MISSED" or event == "RANGE_MISSED" or event == "SPELL_MISSED" or event == "SPELL_PERIODIC_MISSED" or event == "DAMAGE_SHIELD_MISSED" then
local etype, miss
if event == "SWING_MISSED" or event == "RANGE_MISSED" then
missType = select(1, ...)
etype = "SCTD_SHOWMELEE"
else
spellId, spellName, spellSchool, missType = select(1, ...)
texture = select(3, GetSpellInfo(spellId))
etype = "SCTD_SHOWSPELL"
end
if fromPet then etype = "SCTD_SHOWPET" end
miss = getglobal(missType)
if miss then
self:DisplayText(etype, getglobal(missType), nil, nil, nil, destName, spellName, texture)
end
------------interrupts----------------
elseif event == "SPELL_INTERRUPT" then
spellId, spellName, spellSchool, extraSpellId, extraSpellName, extraSpellSchool = select(1, ...)
texture = select(3, GetSpellInfo(extraSpellId))
self:DisplayText("SCTD_SHOWINTERRUPT", SCT.LOCALS.Interrupted, nil, nil, nil, destName, extraSpellName, texture)
end
end



Lines 10-17 should be changeable to see your party pets, not sure if the events support it, but it prolly does

btw:
doesnt the next line express the availability of a dmg filter minimum? (like sctd used to have for mana/health, not at home right now so i cant check)
if (amount < db["SCTD_DMGFILTER"]) then return end

Los
04-16-2008, 02:51 PM
just to toy a bit with it;

find this part of the code


------------damage----------------
if event == "SWING_DAMAGE" or event == "RANGE_DAMAGE" or event == "SPELL_DAMAGE" or event == "SPELL_PERIODIC_DAMAGE" or event == "DAMAGE_SHIELD" or event == "DAMAGE_SPLIT" then
if event == "SWING_DAMAGE" then
amount, school, resisted, blocked, absorbed, critical, glancing, crushing = select(1, ...)
else
spellId, spellName, spellSchool, amount, school, resisted, blocked, absorbed, critical, glancing, crushing = select(1, ...)
texture = select(3, GetSpellInfo(spellId))
end
text = tostring(amount)



add this after the last line



text = sourceName .. "->" .. destName .. " " .. text


you get something like

http://img174.imageshack.us/img174/4458/wowscrnshot041608204941tc8.th.jpg ('http://img174.imageshack.us/my.php?image=wowscrnshot041608204941tc8.jpg')

Los
04-16-2008, 03:33 PM
ITM , did you check this edit out in bg's ? If im right you get dmg on your screen from players in bg partys as well?

The IT Monkey
04-16-2008, 03:50 PM
I have not gone to BGs with SCTD mod installed... I don't do BGs all that much so it is not a concern of mine. What I have read here from people who HAVE gone to BGs with this mod installed they get SCTD for ALL people in their raid... I can see where this would be annoying.

I have not looked into how you might turn the text off for raid members but on for party members. My modification of SCTD was something I just shared with the forum... not something that was meant to be an "end game solution" for all your SCT needs. Like I said... BG is not something I am into so it is not that great a priority for me. If you think this is something you can tackle go for it.

Personally with all the stuff that goes on in BGs I think I would just turn SCTD off before going in.

Nice mod there on the getting it to show names btw... well done. Now if you could just build in a throttle like the other mod has it would be great.

The IT Monkey
04-16-2008, 03:55 PM
doesnt the next line express the availability of a dmg filter minimum? (like sctd used to have for mana/health, not at home right now so i cant check)
if (amount < db["SCTD_DMGFILTER"]) then return end

SCTD does have a filter IIRC... you can set it to NOT show damage under a certain amount. This line of code obviously compares the value of "amount" with that number set in the options. If it is lower it does not return anything.

The IT Monkey
04-16-2008, 03:56 PM
Is there any way that a lua programmer can make extra frames for these?

My idea is to have my Unit frames lined up like this:

Party1 --- Party2 --- Party3 --- Party4 --- Party5

so if there would be 5 extra frames u could scroll them below it like this:

Party1 --- Party2 --- Party3 --- Party4 --- Party5

p1dmg ----- p2dmg ---- p3dmg ---- p4dmg ---- p5dmg
p1dmg ----- p2dmg ---- p3dmg ---- p4dmg ---- p5dmg

I hope it makes sense :pDon't think you need a lua programmer for that ... you need an XML programmer... something I have yet to delve into.

The IT Monkey
04-16-2008, 04:07 PM
I just tried the change and I'm loving it. The only problem is I don't see the party's pet damage. Any idea on what I can replace the pet damage line with to get the damage from all the pets in my party?Try adding
COMBATLOG_OBJECT_TYPE_PET,
with the other modifications... should do the trick.

Although it might only show your mains pet... I don't know if it distinguishes pet ownership.

Your code would look like this:

local COMBATLOG_FILTER_MINE = bit.bor (
COMBATLOG_OBJECT_AFFILIATION_PARTY,
COMBATLOG_OBJECT_AFFILIATION_MINE,
COMBATLOG_OBJECT_REACTION_FRIENDLY,
COMBATLOG_OBJECT_CONTROL_PLAYER,
COMBATLOG_OBJECT_TYPE_PLAYER,
COMBATLOG_OBJECT_TYPE_OBJECT,
COMBATLOG_OBJECT_TYPE_PET,
);


Let me know which of these four things happened:
1) Works as intended.
2) Shows only my main's pet damage.
3) Shows everyone's pet's damage everywhere. (quite possible)
4) Divided by zero and now my computer has fallen into a black hole.

Maxion
04-17-2008, 09:38 AM
I have done bg's with the original edit of sctd from this thread, I do see the damage from everyone in my Party, not Raid, so it's not a big problem for me, in fact I sometimes find it interesting to have such a direct view of how the others are doing.

As far as customizing the way your party's damage etc appears on the screen, I suspect with the customizability of mik's scrolling battle text ('http://wow.curse.com/downloads/details/3395/') you should be able to do that and perhaps more. With the way you can search for events and add them to the thing, I'm sure you could make it look for your alts only, and not whoever is in your party so that it would work regardless of if you are in the same group or not.

firest4rter
04-17-2008, 08:01 PM
I just had a good look at mik's scrolling battle text. If we can get this working nicely with the group this will be heaps better than SCT. Hopefully someone can work out how to make it work like this.

Maxion
04-18-2008, 01:26 AM
Yeah, apparently some of the functions shown in the vid there are not in it anymore since the patch, but I made a post about about it and hopefully he'll get back to me about it/make it work the way we want :D

LancerX
04-19-2008, 11:44 AM
Wow, Nice find IT Monkey. I had been looking for something like this but didnt want to go digging through the lua file :) thanks a ton.

Emo?
04-24-2008, 06:52 PM
Why doesnt it work for me?, ive tryed to do as u said and DL the latest V. of both. Can some1 just paste the whole scrip so i can copy+paste it into my sctd.lua file?

- Thx, Emo? :D

Maat
05-01-2008, 07:04 AM
I just found maybe a bit easier and reliable way to do this.

I updated SCT and SCTD yesterday from wowace so can only talk about version that are at least that old.

Type /sct menu in wow
Go to SCT Custom Events section
Click New Event
Give whatever name you want for the event
At Display type in: *4 (*1)
That will make it look like your damage on main
At Search type in: Shock
Set Event Type to Damage
Set Target to Anyone
Set Source to Friends
Set Event Frame to SCTD
Tick in Show Icon
Click Save Event

Now if your clones are in same guild or on your friend list you will get their Shocks and displayed on SCTD.

Huge problem with this is, if your main is in a guild and guildies are around you shocking you will see their damage too.
Obviously create new event and instead of Shock use Lightning, and you will see all Lightning Bolt and Chain Lightning damage from clones too.

EDIT: Ahh NM, Friend apparently means the whole horde faction :S
Would be nice if it could filter by Character name instead of Spell name tho.

Skuggomann
05-14-2008, 02:14 PM
I was wandering, cant you do somting like this? and jsut put all the names inn there:


COMBATLOG_OBJECT_TYPE_PLAYER:(TOON1),


It wud be great :)

Sina
07-25-2008, 02:20 PM
does this change make the blizzard numbers over the targets head include party damage or is it in the scrolling combat text visuals..... im trying to find a way to make the blizzard damage numbers include my whole party.

Anozireth
07-25-2008, 04:04 PM
I don't think you can mess with the Blizzard UI components. You have to disable them and install this in their place. I'm not 100% sure though.

Ughmahedhurtz
07-25-2008, 04:06 PM
It's only the numbers displayed by SCTD.

Šeceased
07-25-2008, 06:10 PM
does this change make the blizzard numbers over the targets head include party damage or is it in the scrolling combat text visuals..... im trying to find a way to make the blizzard damage numbers include my whole party.

this would be bloody imba tbh ^^ would light up th screen nicely ^^

Mendicant
07-27-2008, 08:00 PM
I just made the fix so I can see my party's damage-- which is awesome btw =) Only thing is that pet damage does not show up for the party. It would be nice to see that also. Anyone know a fix?

entoptic
07-28-2008, 11:52 AM
ok so i added the script to my sct.lua file and I fire up wow.

I make some UI changes and all I can see is healing totems and heals. No damage. Not even my mains damage shows up.

What is up?

Ughmahedhurtz
07-28-2008, 12:12 PM
You typo'd something. ;)

It's not in SCT.LUA, it's in SCTD.LUA.

ramvo
07-28-2008, 02:13 PM
Odd i cant see sctd in my interface option to mess with it. I see sct but no sctd. Clicked on addon to see what mod is in stalled its all checked ok, hmm. What u think i did wrong

ramvo
07-28-2008, 02:20 PM
Hey All,
Did a bit of research today and noticed that SCTD has been updated for 2.4. So I did a little more digging and found what has to be changed to show the entire parties damage.

In the sctd.lua line 50 reads like this:

local COMBATLOG_FILTER_MINE = COMBATLOG_FILTER_MINE

Change it to read like this:

local COMBATLOG_FILTER_MINE = bit.bor (
COMBATLOG_OBJECT_AFFILIATION_PARTY,
COMBATLOG_OBJECT_AFFILIATION_MINE,
COMBATLOG_OBJECT_REACTION_FRIENDLY,
COMBATLOG_OBJECT_CONTROL_PLAYER,
COMBATLOG_OBJECT_TYPE_PLAYER,
COMBATLOG_OBJECT_TYPE_OBJECT
);

COMBATLOG_FILTER_MINE is a WoW filter that usually only calls:
COMBATLOG_OBJECT_AFFILIATION_MINE,
COMBATLOG_OBJECT_REACTION_FRIENDLY,
COMBATLOG_OBJECT_CONTROL_PLAYER,
COMBATLOG_OBJECT_TYPE_PLAYER,
COMBATLOG_OBJECT_TYPE_OBJECT
I simply added
COMBATLOG_OBJECT_AFFILIATION_PARTY,
to the mix and it all went well.

I first tried just changing MINE to FRIENDLY_UNIT... but that was a DISASTER.

Hope you all enjoy.

-J (the IT Monkey)

Edit: Almost forgot... you can download SCTD here ('http://www.wowinterface.com/downloads/dl.php?id=4913') . <--Original file... not modified.I used the default sctd and now i have the option. But if i do the change in lua in stcd i dont have the sctd option in game did i modify it right. I have sct install already (newest one)

entoptic
07-28-2008, 02:22 PM
mebbe I need to redownload the SCTD. I originally looked in there and found nothing so I put in in SCT.lua which had an entry.

I will do some more research and go from there.

Is there a way to color coat the dmg based on who is doing it? :?:

Ughmahedhurtz
07-28-2008, 03:38 PM
Not positive, but you should probably grab both the latest SCT and SCTD to make sure they work together properly. I think you're OK with minor version differences but judging from your technical level, just go grab 'em both and make the mod again to be sure. And don't forget to check the addons list at the character select screen to make sure it's enabled still. ;)

Ughmahedhurtz
07-28-2008, 03:40 PM
mebbe I need to redownload the SCTD. I originally looked in there and found nothing so I put in in SCT.lua which had an entry.

I will do some more research and go from there.

Is there a way to color coat the dmg based on who is doing it? :?:That entry in SCT.LUA is similar but it only works on incoming damage where SCTD is all outgoing. As for color-coding the damage, not unless you have advanced LUA knowledge and can do some pretty major hacks. ;)

Chaosomega
07-30-2008, 03:14 AM
I am kinda confused about this...

I implemented the new things as directed,

But... i could only open this in notepad.

After i did my changes it says i do not have the permission to change the file

I looked for a option to run as administrator and i was unlucky,

Do i have to use a c++ program or whatever to be able to change the sct?

aNiMaL
07-30-2008, 07:34 AM
It might be that the file is read only (slap me silly if you already knew about this and i'm about to explain something you already tried)
Right-click the file,
choose properties,
check if the attribute read-only is selected in the general tab,
if it is, uncheck it, click ok, and try saving it again.

Carnage
07-30-2008, 08:16 AM
Anyone managed to do this with MSBT? used SCT back in kara and changed to MSBT in Black temple - theres no going back ;)

Maxion
07-30-2008, 11:11 AM
Nope. So I use MSBT for my raiding main and SCTD for my multiboxing teams.

ramvo
07-31-2008, 11:07 PM
Thx for the replys guys, got it working now its awsome

roxide
09-12-2008, 05:09 AM
is there a way that this can tell your main what toon is in combat like when a rogue saps you and also tell you when sap effect is done.
also can this tell you when your trinket cooldown is ready from your slave to main?

if you don't know do you know where I can find out this info?

Shox
10-11-2008, 06:30 AM
I have been on the ptr and there is now an option on the combat text tab to show partys damage also so hopefully it can then be throttled to one bit CL crit :P

firest4rter
10-18-2008, 03:42 PM
Just a quick bump to confirm that this still works with the lastest patch.

medk
06-18-2009, 09:24 AM
I have been on the ptr and there is now an option on the combat text tab to show partys damage also so hopefully it can then be throttled to one bit CL crit :PIs this implemented? Have not looked in game yet but saw vid of a multiboxer that showed team damage or are ppl still using this .lua hack?


medK

Ughmahedhurtz
06-18-2009, 07:51 PM
I have been on the ptr and there is now an option on the combat text tab to show partys damage also so hopefully it can then be throttled to one bit CL crit :PIs this implemented? Have not looked in game yet but saw vid of a multiboxer that showed team damage or are ppl still using this .lua hack?


medKThe hack still works, yes. You should see the consecration spam on a pally team AoE'ing. :P