Jamba Map and Quest Log tweaks

[schilm]

Hi all (especially Ebony! ;-) ),

The jamba quest log windows drives me batty every time I open the map/questlog.

So rather than complain, I did something about it... :) I've attached a new JambaQuest.lua file that contains a right click context menu for sharing/tracking/abandoning quests that looks like the following:

1628

Untrack Quest and Abandon Quest work the usual way (JUST on the current toon), Share Quest automatically accepts on toons, per usual.

The additions to the menu are the Jamba UnTrack/Track All Toons and the Jamba Abandon Quest All Toons.

In my testing thus far (somewhat limited) these work fine and I haven't seen any adverse effects elsewhere.


In making this change, I've removed three existing pieces of functionality, but I personally feel the value of this functionality is dubious at best:

1. Abandon All Quests button.
I have never once, in all my years multiboxing, encountered a situation where I WANTED to abandon all my quests... I have accidentally clicked this button (and the associated confirm dialog, as it looks just like the Abandon Single Quest dialog) more than once and have been REALLY irritated because of it...

I just see next to no value in this.

2. Share All Quests button
Somewhat more value here. With the quest specific context menu, and the removal of the irritating window, there isn't a good place for this to live... A button could be added to the questlog to enable this functionality if desired, but I personally don't see the value in adding a lot of extra code to enable this, when you can just share each quest individually... It's sort of nice to have, but not all THAT nice in my opinion.

3. Share/Abandon based on character tags.
I can't possibly envision a scenario where this has any value... It adds a bunch of extra complexity to the code and it just seems utterly pointless... If a toon can accept a quest, why wouldn't you want them to get the quest?


I've commented out the code for the current Quest Log bar as I find it INCREDIBLY irritating. I would REALLY like to see this gone, but if anyone wants it to stay, maybe we could add in a config option that hides it if people don't want to see it?

Generally, I very rarely want to use these Jamba features for quests, so having that bar in your face EVERY time you open the map is just an irritation...

Also, the old window required nearly 500 lines of code and the new mechanism is 162 lines, so it makes things simpler too...


I've attached two files in a zip. JambaQuest.lua contains the changes with the old stuff commented out. JambaQuest-Removed.lua contains the changes and I have deleted the old menu.

1629

[ebony]

Hi all (especially Ebony! ;-) ),

go on am reading :D



The jamba quest log windows drives me batty every time I open the map/questlog.


So rather than complain, I did something about it... :) I've attached a new JambaQuest.lua file that contains a right click context menu for sharing/tracking/abandoning quests that looks like the following:

1628




Ya i did put sometime ago last year about this very old system that was made for the old quest log. that a right click menu would be fun to try just nerver really got around to do it.


Untrack Quest and Abandon Quest work the usual way (JUST on the current toon), Share Quest automatically accepts on toons, per usual.

The additions to the menu are the Jamba UnTrack/Track All Toons and the Jamba Abandon Quest All Toons.

In my testing thus far (somewhat limited) these work fine and I haven't seen any adverse effects elsewhere.



well i was going to do the same sort of thing or-though i was going to use the same Abandon Quest button and using a mod key to send to all toons.





In making this change, I've removed three existing pieces of functionality, but I personally feel the value of this functionality is dubious at best:

1. Abandon All Quests button.
I have never once, in all my years multiboxing, encountered a situation where I WANTED to abandon all my quests... I have accidentally clicked this button (and the associated confirm dialog, as it looks just like the Abandon Single Quest dialog) more than once and have been REALLY irritated because of it...

I just see next to no value in this.



I use this a LOT! i mean a LOT as well! its so helpful! from login on a team after a few years and just looking at the quest log and meh delete it. i can not say i nerver miss clicked that button in all the years av used it.

Maybe we need more confirm dialog hmmmmmm,






2. Share All Quests button
Somewhat more value here. With the quest specific context menu, and the removal of the irritating window, there isn't a good place for this to live... A button could be added to the questlog to enable this functionality if desired, but I personally don't see the value in adding a lot of extra code to enable this, when you can just share each quest individually... It's sort of nice to have, but not all THAT nice in my opinion.

3. Share/Abandon based on character tags.
I can't possibly envision a scenario where this has any value... It adds a bunch of extra complexity to the code and it just seems utterly pointless... If a toon can accept a quest, why wouldn't you want them to get the quest?




the share all quest button can come in handy if you added a new toon to the group and wonted to sync that new char to the group. why i keep it.

The tag system is well ya i nerver used it. i understand stand whats its for say you only wonted only the class quests on xyz chars but then again its not like you can share it to them chars anyway ya i know this is more of less as useful as a chocolate teapot.





I've commented out the code for the current Quest Log bar as I find it INCREDIBLY irritating. I would REALLY like to see this gone, but if anyone wants it to stay, maybe we could add in a config option that hides it if people don't want to see it?



hmm ya right hmmm right there is a option to turn it off already its always been there. (surly you saw that going though the code!)




Generally, I very rarely want to use these Jamba features for quests, so having that bar in your face EVERY time you open the map is just an irritation...

Also, the old window required nearly 500 lines of code and the new mechanism is 162 lines, so it makes things simpler too...




well yes i did make the bar smaller last year and after i was going to remove it a lot wonted to see it stay, like i said there is something i wonted to do and was thinking a right click menu would be a lot easier so i will try and it and see i might add it in the 4.3 beta release and see what kinda (if) feed back we get on it?

[schilm]

The share all and abandon all are potentially useful, yes, but if there is an alternate means of doing it one by one AND there are a maximum of 25 items you need to Abandon or Share AND it is something you are doing relatively infrequently...

If it were me, I certainly wouldn't want to leave that complexity in the code, that needs to be maintained, to account for such an infrequent activity...

Obviously it's up to you, you're the one maintaining this, but 500 lines of code is a LOT of cruft for a feature such as that...


As to disabling the bar, somehow I never noticed the option for that! So that works for me then.

If you could integrate the changes for the right click menu, that adds back the Track functionality which *I* use and have been missing, and I can now disable the bar so that gets it out of the way, so everyone wins!


One other option I had considered for Share All and Abandon All would be a slash command. It's definitely an infrequent thing to do so, if you did want to consider getting rid of the bar, rather than trying to shoehorn Share All and Abandon All buttons into the questlog where there really isn't a good place for it, a slash command could solve the problem... Just an idea.


Thanks,
Max

[luxlunae]

My problem with Abandon all quests is that it seems to bug out and get stuck because of account wide (pet) quests. I'd like to see those excluded from the feature.

[Dadjitsu]

now the abandon all feature I do use, when I start to out level an area by a few levels I move on and abandon all.

[schilm]

Ok, so I seem to be in the minority not liking the AbandonAll and ShareAll functionality.

So, I went through and implemented that in a new way.

Rather than the large clunky old bar, there is now a small bar with small icon buttons that shows up underneath the quest log in the Quest/Map frame. I just picked four random box icons, easy enough to change to something else if anyone has any better ideas...

This bar is still controlled by the old config option, so it can be hidden if desired.

This new bar has four buttons:

Abandon All


Works just like it used to. It loops through all of your toons and abandons all the quests on each toon.
NOW ignores quests that cannot be abandoned, such as the Account Wide quests Luxlunae mentioned.


Share All

Used to just loop through the current toons quests and just shared those, NOW loops through all toons and attempts to share all quests from all toons.


Track All

Back from the abyss!!!
Used to just loop through the current toons quests and just tracked those, NOW loops through all toons and attempts to track all quests from all toons.


Untrack All


Back from the abyss!!!
Used to just loop through the current toons quests and just untracked those, NOW loops through all toons and attempts to untracks all quests from all toons.


I have removed the old bar from the code as the only difference now is the tag functionality which cluttered things up and I just can't see value there.

1630

[luxlunae]

Yeah, I definitely like it because I'll quest a toon for a while, then they may end up on a team for another 30 levels and then I've got quest clutter that needs abandon all. Or just moving on from a zone if I'm doing quest leveling I like a nice clean slate. I'll try out your extension schilm. And thanks again, for maintaining the addon ebony!

[schilm]

Yeah, I definitely like it because I'll quest a toon for a while, then they may end up on a team for another 30 levels and then I've got quest clutter that needs abandon all. Or just moving on from a zone if I'm doing quest leveling I like a nice clean slate. I'll try out your extension schilm. And thanks again, for maintaining the addon ebony!

Yea, when I started thinking about it, I can see the draw of it... I've never personally used the "All" buttons, but I've never really had all that many teams. I guess I just hated the old UI so much it clouded my thinking! ;-)

Anyway, let me know if the abandon functionality works as you would like with the account wide quests (seems to skip the garrison pet quest for me).

Thanks,
Max

[ebony]

getting




1x [ADDON_ACTION_BLOCKED] AddOn 'Jamba-Quest' tried to call the protected function 'CompactRaidFrame14:Show()'.!BugGrabber\BugGrabber .lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\CompactUnitFrame.lua:290: in function `CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:248: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:100: in function <FrameXML\CompactUnitFrame.lua:47>


Locals:

[schilm]

Do you have a full error stack? or error line? Where do you get the error? On load? On questlog open?

The string "raidframe" does not exist in the updated addon... so without some more context, I don't know how it could be calling "CompactRaidFrame14:Show()"

[ebony]

Do you have a full error stack? or error line? Where do you get the error? On load? On questlog open?

The string "raidframe" does not exist in the updated addon... so without some more context, I don't know how it could be calling "CompactRaidFrame14:Show()"





ya don't know why its calling it but its calling it when i enter a bg.

[schilm]

I just entered Ashran and got that error from SpartanUI:


1x [ADDON_ACTION_BLOCKED] AddOn 'SpartanUI_Artwork' tried to call the protected function 'CompactRaidFrame13:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Show'
FrameXML\CompactUnitFrame.lua:290: in function `CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:248: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:100: in function <FrameXML\CompactUnitFrame.lua:47>


Locals:


Don't get it related to Jamba-Quest though...

[ebony]

after a little reading its called taint

"Basically, some addons that - for example - don't have certain variables localized correctly will taint secure functions."

here some posts.

http://us.battle.net/wow/en/forum/topic/6607331970 (http://us.battle.net/wow/en/forum/topic/6607331970)
http://us.battle.net/wow/en/forum/topic/8569857326#5

[schilm]

I can only assume this has something to do with replacing the default right click menu on the quest log, but I've tried and frankly can't find any other means of doing it. In fact MANY other addons have nearly the exact same code for dropdown menus that I employed here... There was a "NoTaint_DropdownMenu" addon someone released years ago, but it doesn't seem to have been maintained in many years. I tried it, but I couldn't get it to function.

All that said I haven't encountered a single problem related to this error. All seems to work perfectly fine in Jamba and everywhere else in my testing...

I installed BugGrabber and played for many hours. I have a slew of addons so while I haven't seen this particular error from Jamba Quest pop up, I get a boatload of this type of error from various addons going into and out of battlegrounds, joining raids, etc...

I haven't seen any errors or problems with this or any odd behavior anywhere else in the game. Has this caused any issue for you?

[ebony]

I can only assume this has something to do with replacing the default right click menu on the quest log, but I've tried and frankly can't find any other means of doing it. In fact MANY other addons have nearly the exact same code for dropdown menus that I employed here... There was a "NoTaint_DropdownMenu" addon someone released years ago, but it doesn't seem to have been maintained in many years. I tried it, but I couldn't get it to function.

All that said I haven't encountered a single problem related to this error. All seems to work perfectly fine in Jamba and everywhere else in my testing...

I installed BugGrabber and played for many hours. I have a slew of addons so while I haven't seen this particular error from Jamba Quest pop up, I get a boatload of this type of error from various addons going into and out of battlegrounds, joining raids, etc...

I haven't seen any errors or problems with this or any odd behavior anywhere else in the game. Has this caused any issue for you?


there was a few problems i saw with blizzard raid frames not updating right if new players came in.

Still i don't like lua errors and the bug reports am going to keep getting will do my head in. so unless i can find a way to fix it will not make the mainline release or though a lot of the code is still helpful the new frame is a lot better then the old one.
But with the DropdownMenu and the errors and problems that will prob get removed and they have to be be buttons on the frame. let me know what you think??

[schilm]

From what I have seen in game, I only see *anything* related to this type of "taint" error with bug grabber installed. I've noticed no issues anywhere else in the UI. Something is definitely happening in the background that is slightly wonky, but I haven't seen any explicit breaking problems from it anywhere. And frankly, I haven't even seen the BugGrabber error related to Jamba-Quest at all, just related to other various addons I use.

As far as pulling the old code, and just using the bar without the context menu, I don't think that will work as you'll then lose the ability to select and abandon /track/untrack a single quest (share would still work correctly I believe though)

While the old code is somewhat kludgey with the mechanisms for selecting a quest in the questlog, without the context menu, its kind of necessary and you're losing functionality if you remove it.

As a software developer for many years, I've come to the opinion that you can never eliminate this type of "warning" from your code and you'll go mad trying... So unless there were explicit breaking issues, I'd personally run with it... but that said, it's your addon and I (and many others) greatly appreciate the work you've done on it, so if you're not comfortable with the errors then that's what it is.

I'll look around and see if I can find a different means of generating the right click context menu, but being that I haven't even see the Bug Grabber error related to Jamba-Quest and there aren't any other explicit issues to be looking for, I'm not sure how much success I'll have...

[ebony]

From what I have seen in game, I only see *anything* related to this type of "taint" error with bug grabber installed. I've noticed no issues anywhere else in the UI. Something is definitely happening in the background that is slightly wonky, but I haven't seen any explicit breaking problems from it anywhere. And frankly, I haven't even seen the BugGrabber error related to Jamba-Quest at all, just related to other various addons I use.

As far as pulling the old code, and just using the bar without the context menu, I don't think that will work as you'll then lose the ability to select and abandon /track/untrack a single quest (share would still work correctly I believe though)

While the old code is somewhat kludgey with the mechanisms for selecting a quest in the questlog, without the context menu, its kind of necessary and you're losing functionality if you remove it.

As a software developer for many years, I've come to the opinion that you can never eliminate this type of "warning" from your code and you'll go mad trying... So unless there were explicit breaking issues, I'd personally run with it... but that said, it's your addon and I (and many others) greatly appreciate the work you've done on it, so if you're not comfortable with the errors then that's what it is.

I'll look around and see if I can find a different means of generating the right click context menu, but being that I haven't even see the Bug Grabber error related to Jamba-Quest and there aren't any other explicit issues to be looking for, I'm not sure how much success I'll have...

right but i uninstalled bug grabber and it still does it, it block lots of blizzard UI buttons/menus - so they don't work try leaving a que and nothing happens errors change from time to time what loads up 1st.

the only i can think of is doing like the other mutiboxing addons that just uses the blizzard button and just sends the msg to remove them on the clones when that is called.


but i already had few friends test this and are having the same problem as me, but thanks for the help if players would like to use this then they can but ill see what happens if anything to get added. am not sure if its a EU/US thing? if your saying you seeing no problems at all.


Edit:: I think i found the bug:



table.insert(UISpecialFrames, yourframehere)


using this code seems to fix a lot of the errors i was getting one was if a StaticPopupDialogs that was made by isboxer (wrong char in wrong slot) and then jamba-quest was trying to over right braking all blizzard StaticPopupDialogs.

anyway ill test it with this code and see if i see anymore errors

http://www.wowinterface.com/forums/showthread.php?t=41455

[schilm]

OK, so you ARE seeing some real problems that you think are attributed to this? You had only said there seemed to some issues with the raid frames updating, which didn't seem like a critical problem...


I'll test some more this evening once the servers come back up from maintenance , but no, I have not seen any problems whatsoever. I've entered bgs, left bg queues, left bgs, entered dungeons, left dungeon queues, left dungeons, converted group to raid, converted back to group... nothing.


Can you be more explicit with a solid bug report detailing exactly what you are seeing and explicit steps you take for it to happen?

Also, which other addons do you use?

Thanks,
Max

[ebony]

OK, so you ARE seeing some real problems that you think are attributed to this? You had only said there seemed to some issues with the raid frames updating, which didn't seem like a critical problem...


I'll test some more this evening once the servers come back up from maintenance , but no, I have not seen any problems whatsoever. I've entered bgs, left bg queues, left bgs, entered dungeons, left dungeon queues, left dungeons, converted group to raid, converted back to group... nothing.


Can you be more explicit with a solid bug report detailing exactly what you are seeing and explicit steps you take for it to happen?

Also, which other addons do you use?

Thanks,
Max

well am not sure its just this doing it but if i go back to the old Jamba_quest it does not do it.

Its defo taint. the way i found it causing if if you get the isboxer StaticPopupDialogs to show and then (jamba_quest Or though that what it says) starts the blocking the UI. so i would think its StaticPopupDialogs that is taint

My changes have fixed the RaidFrames problams its just the the superLocked down BG button.



1x [ADDON_ACTION_FORBIDDEN] AddOn 'Jamba-Quest' tried to call the protected function 'JoinBattlefield()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `JoinBattlefield'
Blizzard_PVPUI\Blizzard_PVPUI-1.0.lua:524: in function `HonorFrame_Queue'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>


Locals:
nil


Tainit.log


4/12 18:09:43.397 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :518 HonorFrame_Queue()
4/12 18:09:43.397 An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:09:43.397 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :524 HonorFrame_Queue()
4/12 18:09:43.397 HonorFrameSoloQueueButton:OnClick()
4/12 18:10:07.359 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :518 HonorFrame_Queue()
4/12 18:10:07.359 An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:10:07.359 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :524 HonorFrame_Queue()
4/12 18:10:07.359 HonorFrameSoloQueueButton:OnClick()
4/12 18:10:09.272 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :518 HonorFrame_Queue()
4/12 18:10:09.272 An action was blocked because of taint from Jamba-Quest - JoinBattlefield()
4/12 18:10:09.272 Interface\AddOns\Blizzard_PVPUI\Blizzard_PVPUI.lua :524 HonorFrame_Queue()
4/12 18:10:09.272 HonorFrameSoloQueueButton:OnClick()


More detailed log


4/12 18:15:27.616 LoadAddOn()
4/12 18:15:27.616 Interface\FrameXML\UIParent.lua:343 UIParentLoadAddOn()
4/12 18:15:27.616 Interface\FrameXML\UIParent.lua:422 TimeManager_LoadUI()
4/12 18:15:27.616 Interface\FrameXML\UIParent.lua:923
4/12 18:15:27.616 Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:27.616 Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()
4/12 18:15:27.616 Interface\AddOns\Jamba-Quest\JambaQuest.lua:1797 initFunction()
4/12 18:15:27.616 Interface\FrameXML\UIDropDownMenu.lua:69 UIDropDownMenu_Initialize()
4/12 18:15:27.616 Interface\AddOns\Jamba-Quest\JambaQuest.lua:192
4/12 18:15:27.616 xpcall()
4/12 18:15:27.616 safecall Dispatcher[1]:9

-----------------------------------------------------------------------------------

4/12 18:15:28.285 Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:28.285 Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:478 initFunction()
4/12 18:15:28.285 Interface\FrameXML\UIDropDownMenu.lua:69 UIDropDownMenu_Initialize()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:462 CompactUnitFrameProfilesGeneralOptionsFrameSortByD ropdown:updateFunc()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:184 CompactUnitFrameProfiles_UpdateCurrentPanel()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:171 CompactUnitFrameProfiles_ActivateRaidProfile()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:45 CompactUnitFrameProfiles_ValidateProfilesLoaded()
4/12 18:15:28.285 Interface\AddOns\Blizzard_CUFProfiles\Blizzard_Com pactUnitFrameProfiles.lua:25
4/12 18:15:28.285 Execution tainted by Jamba-Quest while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:706 UIDropDownMenu_GetSelectedID()
4/12 18:15:28.285 Interface\FrameXML\UIDropDownMenu.lua:436 UIDropDownMenu_AddButton()




You can find me in the live irc chat if you want to talk to me about it.



Edit2:::

http://us.battle.net/wow/en/forum/topic/15007380994

seem to be the problem(bug) i have found that is couseing this problam

[schilm]

Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y? :)

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half usign the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max

1632

[schilm]

One other thing to try:

The code I was using added the dropdown buttons as follows:

UIDropDownMenu_AddButton(info, UIDROPDOWNMENU_MENU_LEVEL);

but level is an optional parameter and we aren't concerned with level here. So I just changed to this:

UIDropDownMenu_AddButton(info);

and it works fine for me

Try that and see if it makes a difference for you?

Thanks,
Max

[ebony]

Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y? :)

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half using the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max

1632


sounds like the way it should be done the problem i found and read is with taint-y? is it could be some other addon (even blizzards) own code that when jamba-quest is using it after is making the problems. but its so random and does so many random things for sure something is not right. ill test this and see if i can found anything wrong ;) all being well sounds like it should not be as taint-y, we don't want taint errors

Thanks for the hard work on the module.

Oh i don't like the icons am getting trying to get someone to make some nice new ones for us :)

[schilm]

I despise the icons as well!

The bags are dumb, but I couldn't find any existing icons that made any sense whatsoever, so... I picked bags. 'cause there were four of them. And I needed four buttons.

:)

It's still possible we'll need to replace the dropdown code with some alternative approach, but the new code is definitely better. (FYI, the zip file does NOT contain the removal of the UIDROPDOWNMENU_MENU_LEVEL parameters, you'll need to delete those yourself.)

[ebony]

1633
Hey Ebony,

I played around with it and redid the mechanism for creating the right click menu. Essentially in the version you are working with I was cheating my way into the existing dropdown_init mechanism for the existing right click dropdown menu and replacing it.

I figured out a different means of creating the right click menu, but using the ACE3 RawHookScript method to essentially OVERRIDE the existing click event utilize a totally new dropdown menu rather than modifying the existing one.

Again, I can't reproduce the issues you're seeing, I saw one error joining a battleground this morning, but couldn't ever reproduce it again, but this approach also works without issue for me and SHOULD be cleaner and less taint-y? :)

Also, the benefit here is that using this approach we can work in a completely different dropdown or menu system for the right click event whereas before it was half usign the existing dropdown and associated events, so it couldn't be replaced.

Try this out and let me know if you still get the errors. Worst case I can now freely replace the dropdown menu with something different if you still see issues and that should totally solve it.

Thanks,
Max


ok i think i found the few problems there was should be taint free now.


if u wonted to see what i done. ill get this added to 4.3 Beta release for more testing soonish

1633