PDA

View Full Version : [WoW] Jamba Extension for choosing which character loots Motes of Harmony (or any item)



schilm
10-17-2012, 02:48 PM
Hi all,

I've written an extension to Jamba that allows you to control how your group loots items. It allows you to choose an item and then pick a member of your team and say that toon will always loot that particular item and no other toon can loot that item.

In addition, whenever another toon encounters that item a Jamba Alert will show up in the center of your screen telling you which item was found and which toon is allowed to loot that item.

When that happens just spam Interact with Target on the corpse and the proper toon will loot and get the item.

I've spoken with Jafula and hopefully we can get this included into the Jamba package either in this release or the next one, but I wanted to get it out there for some testing ahead of time.

It seems to work pretty well in my testing here (5 boxing) but the more eyes on it the better.

You can grab the addon from here:

https://github.com/seaglass/jamba-advanced-loot/zipball/master

INSTALLATION

just create a folder in your wow addons directory named Jamba-AdvancedLoot and copy the contents of that zip file into there. (Make sure the JambaAdvancedLoot.lua file is in the Jamba-AdvancedLoot folder and not in a subfolder)


SETUP

I was able to use the AWESOME hooks jafula has inside of Jamba and easily get a nice administration UI built that will, like all other pieces of jamba, share settings with the other toons in your group.

The administration options show up (for now) under the Team heading on the left nav bar inside of the jamba administration panel (/jamba)

The setup is pretty straightforward with a few caveats.

Enable Advanced Loot

This tells the addon whether to fire or not. Turn this off and it will go back to normal looting. (If you have Manage Auto Loot set, it will turn AutoLoot on when you disable and turn AutoLoot off when you enable)

Manage Auto Loot

This allows the addon to automatically DISABLE autoloot while it is enabled and you are in a group. It will also try to RE-enable autoloot when you leave the group or when the addon is disabled. This isn't essential, but it is a nicety to keep you from needing to go back into the settings if you are playing a character by themselves.

Auto Close Loot Window On Slaves

This is a workaround for an issue I ran into whereby when you are looting a quest item on all toons with Interact with Target the loot window opens but for whatever reason one or more of the slaves don't loot the items. In this case, Interact with Target sees the window open, so it will not re-open and therefore won't loot.

What this option does is force the window closed on the slaves after it tries looting a few times. That way you can just hit Interact with Target again and it will retry the whole operation.

The downside of this is that the loot window never shows on the slaves so if you are looting a BoP item it will only be visible on your master toon. I have some ideas about possibly detecting BoP items or just auto-disabling this option when you go into a dungeon but I haven't gotten that far yet.

Adding Items

This is pretty straightforward, just drag the item you want into the item box, choose character you want to loot that item from the dropdown and hit add. Then MAKE SURE you push the settings to your other toons.


After that you should be good to go.

Please post any issues you encounter in this forum and I'll try to address them as quick as possible.

Also, you need to be sure you have any other auto looting addons disabled (such as EasyLoot). If they are enabled they will just override what this addon does and loot based on their own settings.

FYI: This addon assumes you have Free For All looting set.


Thanks,
Max

Khatovar
10-17-2012, 10:56 PM
Doesn't like alt characters used in toon names. Using Messkit is fine, but trying to select Çroaker, Lìfetaker or Wìdowmaker from the dropdown gives the error -


[22:53:06] JambaAdvancedLoot: Character name must only be made up of letters and numbers.

schilm
10-17-2012, 11:10 PM
Oops, easy fix. Grab the latest and it should allow alt characters.

Multibocks
10-17-2012, 11:22 PM
oooh sweet I cant wait for this to be part of Jamba!

JohnGabriel
10-18-2012, 01:36 AM
This will help with the motes for sure.

propagandalf
10-18-2012, 09:27 AM
Nice job, thanks! I'll be trying it out for sure. :)

Shodokan
10-18-2012, 12:42 PM
I'll have to try it, but good job with the initiative in doing it yourself opposed to just making a suggestion for it.

luxlunae
10-18-2012, 12:43 PM
I'm not even playing right now but thanks for enhancing lives!

Shodokan
10-18-2012, 09:02 PM
Testing it farming for an hour, will report back.

Shodokan
10-19-2012, 09:24 AM
While using this I get lots of changing in master/follow patterns, otherwise it works. (doesn't happen when this addon is disabled)

schilm
10-19-2012, 09:51 AM
Can you give some examples? I'm not clear on exactly what you mean by "changing in master/follow patterns"

The only thing the addon does is hook into the LOOT_OPENED and GROUP_ROSTER_UPDATE events.

LOOT_OPENED is the event that fires when the loot window opens

GROUP_ROSTER_UPDATE is the event that fires when the party members change (this is only used if you have Manage Auto Loot enabled)


There definitely could be some side issues or other side effects, but I've been using it with my melee questing group for the past two days and I haven't noticed any difference in the follow behavior of the group or really any differences at all besides the additional functionality the addon provides.

- Max

Shodokan
10-19-2012, 09:59 AM
After looting a few times and NOT switching windows (happens about once per 5-8 mins) it would start following one of my other toons even when follow after combat was turned off (happened with and without it on).

This problem does not occur without this addon actually running/active.

schilm
10-19-2012, 10:25 AM
So I want to make sure I understand so I can look for the behavior in my testing

These are the steps that I follow, I'd guess they would be similar to yours:

(all actions take place with the master window active, ie I never switch windows)

NOTE: I have follow after combat disabled in my setup.

1. Kill a mob or a group of mobs
2. Right click to loot the corpse from the master
IF a Mote of Harmony is found and a Jamba alert is displayed
2a. Click the corpse again with the mouse on the Master window
2b. Spam the Interact with Target button to get all the characters to loot the corpse and the correct toon loots the Mote of Harmony
2c. Sometimes the item still doesn't get looted, repeat steps 2a - 2b until it does (almost always works on the first time, rarely need a second or third)
3. Mount up on all toons
4. Hit Follow button to get other toons to follow the master
5. Move to next mob or group of mobs
6. Repeat steps 1-5


At which point does the follow issue happen?
Is it the master that starts following one of the slaves?
Or does one of the slaves start following the master?
If it is one of the slaves that starts following the master, is it always the same slave that starts following the master or is it random?

fr0z3night
11-02-2012, 01:07 PM
Big thanks for this works great. And using it with interact with target, which I only really found out about because I found this addon *face palm*

Though wouldn't mind if you could have more than 1 character be able to pick up the item, in like a round robin, as my current group has blacksmith and inscription, though definitely great that my miner can't pick it up.

schilm
11-02-2012, 01:28 PM
Round Robin would be pretty tough to implement because you need to track who looted last and figure out a way to communicate that with everyone...

I just swap the characters regularly... one day I will have my tailor loot, next day I will have my scribe loot, etc...

I could remove the restriction that allows only one toon to loot an item, that way it would be a race to see who get there first and gets to loot... but unfortunately it wouldn't necessarily be random or 50/50. For instance if one toon is melee and the other is a caster, the melee toon will almost always get there first and would thus, almost always loot the item.

and I think lag / key broadcast software could impact it as well... ie, due to the way the key broadcast systems work, the interact with target commands get sent down to the other windows in the same order (I believe) so the window that gets the command first is going to start moving first and thus get the item the vast majority of the time...

Sildenafil
11-23-2012, 11:34 PM
I'm having a bit of trouble getting started with this extension. I downloaded it and created an exact copy of the folder name you suggested in my WoW addons directory, then extracted the .zip to that folder. You said to make sure the .lua is in the created folder, so I moved it there. I am not seeing any options under Jamba-Team, or anywhere in Jamba, regarding advanced loot. To check, I copied the .lua and placed a copy of it back in the original folder it came in, and no change. I also am not seeing it under the WoW addons in game as a clickable jamba subroutine.

I'm sure I'm having a Der-te-Der moment, but could somebody help me out?

Thanks.

Khatovar
11-24-2012, 01:35 AM
You need to take everything out of the folder. You should have the zip seaglass-jamba-advanced-loot-aa2887b. In that zip should be a folder with the same name. In that folder should be a folder called Locals and the files "copy", "JambaAdvancedLoot.lua", "Jamba-AdvancedLoot.toc" and "README.md".

Those files need to be copied as they are into a new folder called called Jamba-AdvancedLoot in Interface/AddOns. Or extract the seaglass-jamba-blahblahblah folder and rename it to Jamba-AdvancedLoot and put it into Interface/AddOns.

The end result should be a folder in Interface/AddOns called Jamba-AdvancedLoot. In that folder should be the folder Locals, the files "Copy," "JambaAdvancedLoot.lua," "Jamba-AdvancedLoot.toc" and "README.md". In the folder Locals should be JambaAdvancedLoot-Locale-enUS.lua and Locales.

Sildenafil
11-24-2012, 11:43 PM
Thanks, Khatovar!

Sildenafil
11-26-2012, 12:27 AM
Used this add-in for a couple play sessions now (Thanks, Khat, for the advice). Very nice program that does what it's supposed to. I notice a small issue though, which you have already mentioned. The issue with auto-closing loot window: It seems to do something funky on every window, main included, that spams the blizz pop-up text with error text 'object is busy" or "another action in progress" or something like that a few times every time I loot something on the main, which messes with quest-tracking pop-ups like "4/6 Fuzzy muscrats collected" or whatever. A relatively minor issue, but I'm wondering if there would be a work-around to have the "auto-close loot window" feature disabled if the character is in the main window, or something like that. I'll keep using this program regardless, because it's awesome, but that's the one bit of constructive criticism I can think of.

Thanks a lot for the effort.

luxlunae
12-04-2012, 04:21 PM
is this supposed to be used on master loot or free for all?

schilm
12-04-2012, 04:28 PM
Free for all... I always play with free for all, and I haven't tested it with any other loot method.

MiRai
12-04-2012, 04:29 PM
is this supposed to be used on master loot or free for all?
Free-For-All


FYI: This addon assumes you have Free For All looting set.

EDIT: Beat me to it!

Jafula
12-05-2012, 02:56 PM
P.S. This addon is now part of Jamba (as at 5.1.1), you can find it under Team -> Advanced Loot.

drarkan
12-20-2012, 03:44 PM
Heh found this thread when I noticed Advanced loot since updating, enabled it no knowing what it is, then figured, "check the forums" Great addition! I will implement this when I see its needed! Great work Schilm! Thanks Jafula for incorporating it into Jamba!

Brandish
11-17-2013, 07:18 AM
Such a long time and I didn't know about this. Next thing someone will tell me FTL support is in Jamba or some such....

Anyways, I'm on Timeless Isle... and the epic items drop from normal mobs occasionally.... cringed when two fell back to back, but I got lucky and slave that needed the item got the item. Whew.

Using this advanced loot, I can set up which char will loot them, so whoever needs boots will loot boots.... oh no... i just noticed they have the "You can trade this with another eligible player..." on them.... ah well.... still good for motes ;-) (I thought they turned that off trading thing off at one point... oh well :) )

Thanks for the plugin and thanks of course to Jafula for keeping Jamba going.

OK... looking at this some more, one item that dropped can be traded, the other on cannot. The one that can be traded can be used by other chars, the one that cannot it for a spec that isn't in the group. So that means, with enough setup, you can use this feature to funnel items to the char with the alt on it's account that needs the, say, cloth upgrade.

But thing brings up the question... is there a way to add items to be governed by Advanced Loot that you don't posses? :)

Brandish
11-17-2013, 08:36 AM
Hmm. Now I'm concerned that if a toon is told it's not suppose to loot, say, the glove item, that if a it comes from one of the chests, or from one of the rares, it will leave it. (Everyone gets their own loot roll on rares)

Hmm. And Auto closing the loot window fails for the BoA Windfeather Plume.

moosejaw
11-22-2013, 10:33 PM
You know you can mail the armor caches (timeless isle) to your alts right? There is no concern about who loots what and when, just mail it to the toon that needs it when your gaming session is done.

ebony
11-23-2013, 09:40 AM
You know you can mail the armor caches (timeless isle) to your alts right? There is no concern about who loots what and when, just mail it to the toon that needs it when your gaming session is done.

if there on the same battle.net.

Saying that if your in the same group you can trade the item like dungeon loot for 2 hours!

moosejaw
11-23-2013, 10:22 PM
Doh! I forgot about that. Trading like dungeon loot would be nice too.

Tehtsuo
09-14-2014, 04:39 PM
I'm wondering if I'm doing something wrong - I can't seem to get this to work, and the only reason I need it is for those stupid motes of harmony. If I click loot with my main, it sees the mote and tells me to loot on my alt (priest) I have specified. If I then broadcast my interact with target, my melee characters all loot and snag the mote. I'm assuming this isn't supposed to just be a loot alert so you loot with the right character - I need it to PREVENT my other characters from picking it up.

I do have auto loot turned off, so this is actually performing the loot on the alts...

Tehtsuo
09-14-2014, 07:08 PM
Correction, it looks like I had another addon that was causing that problem. Issue resolved - would it be possible to add a "this character loots blue BOPs" option?

luxlunae
09-14-2014, 08:54 PM
Correction, it looks like I had another addon that was causing that problem. Issue resolved - would it be possible to add a "this character loots blue BOPs" option?

not sure why you'd need that, presumably you want to DE? if you have it on group loot then just click disenchant on the master? I guess if you really hate group loot this wouldn't work.

There is also an autoroll addon called passloot that can take some of the annoyance out of looting. You could simply set everyone else to ignore blues they cannot use and the specific toon to greed/de on them.

Tehtsuo
09-14-2014, 09:08 PM
not sure why you'd need that, presumably you want to DE? if you have it on group loot then just click disenchant on the master? I guess if you really hate group loot this wouldn't work.

There is also an autoroll addon called passloot that can take some of the annoyance out of looting. You could simply set everyone else to ignore blues they cannot use and the specific toon to greed/de on them.

Group loot and this addon are mutually exclusive. Beyond that, group loot prevents loot being a common pool, so you have to loot every corpse on every character to get all the sparklies. I run FFA and this addon is fixing the problem of the motes. However, it also makes it so anything any character can loot that isn't a mote is looted - including BOP blues which I'd prefer to disenchant. Right now I can trade the BOP blue to my enchanter, but I'd prefer if I could just prevent any other character from picking up and let him pick it up.

I realize I could add every dungeon blue bop to the list with my enchanter as the target, but that's.... a lot of items. ;)

Khatovar
09-15-2014, 08:43 AM
You can try looking at the stuff mentioned in this thread.

http://www.dual-boxing.com/threads/49106-Something-changed-with-loot-method-after-5-2

Tehtsuo
09-21-2014, 06:14 PM
Well, I decided to dig into this module's guts. I made some changes to how it works and added some features. I'm going to reply to the main jamba thread with my tweaks in the hopes that Jafula likes them and wants to include them in his package.

rfarris
09-22-2014, 08:51 AM
The update with your (Tehtsuo) changes have been ratified by the author and is posted on Curse.

Tehtsuo
09-22-2014, 08:56 AM
The update with your (Tehtsuo) changes have been ratified by the author and is posted on Curse.

I saw that but I would give warning that Jafula made some changes and I don't believe the version on Curse will behave the way I designed it to. I explained my reasoning in the Jamba release thread, so hopefully he'll tweak it again and upload a new version to Curse.

rfarris
09-23-2014, 09:18 AM
> so hopefully he'll tweak it again...

He did. And your two-pass loop is back in and it is up on Curse.

Khatovar
09-23-2014, 09:49 AM
Closing this thread because it has now been necro'd, crossposted and hijacked.

Schlim hasn't visited these forums in nearly 2 years and this was handed over to Jafula almost as soon as he created it. Any discussion of it belongs in the latest Jamba thread, which is always stickied at the top of the Macros and Addons section (http://www.dual-boxing.com/forums/14-Macros-and-Addons).

R.I.P. thread.