PDA

View Full Version : Why Would 4.0.1 Break This Macro?



Mercurio
10-21-2010, 10:44 PM
Hey guys,

I've used this macro as a general accept macro for a long time. With the introduction of 4.0.1, it will no longer accept group invites.

I can click Accept on group invites, but the macro no longer works. It is very odd b/c I've quintuple-checked the syntax and taken portions of the macro that contain the AcceptGroup(); portion into other macros and it works just fine. The other parts seem to work fine as well. What simple thing am I missing?

/run AcceptGroup();ConfirmSummon();AcceptQuest(); AcceptTrade(); RetrieveCorpse(); RepopMe();StaticPopup_Hide("PARTY_INVITE");
/click LFDRoleCheckPopupAcceptButton;
/click LFDDungeonReadyDialogEnterDungeonButton;StaticPopu p_Hide("CONFIRM_SUMMON");

ocuus
10-21-2010, 11:00 PM
/click LFDDungeonReadyDialogEnterDungeonButton;StaticPopu p_Hide("CONFIRM_SUMMON");

is there supposed to be a space between the u and p for StaticPopup_Hide ????

just a though thats the only thing that looks out of place

Ughmahedhurtz
10-21-2010, 11:21 PM
If I had to guess, I'd say the problem is combining a /click with a normal script command in line 3.

/click != /run

So your new macro would look like this:

/run AcceptGroup();ConfirmSummon();AcceptQuest(); AcceptTrade(); RetrieveCorpse(); RepopMe();StaticPopup_Hide("PARTY_INVITE"); StaticPopup_Hide("CONFIRM_SUMMON");
/click LFDRoleCheckPopupAcceptButton
/click LFDDungeonReadyDialogEnterDungeonButton

Mercurio
10-21-2010, 11:31 PM
Thanks for the replies.

ocuus, not sure what that space is in my post. Checked it and it isn't in my macro.

Ughmahedhurtz, I tried your switch and it still isn't working. Same issue - other parts of the macro still work.

Looking at the problem a little further, when I execute the macro the inviter gets a message that the character declined my group invite (not before I click it, so it isn't like an auto-decline thing).. Any other thoughts?

Jafula
10-21-2010, 11:42 PM
Addons auto declining for you. Jamba does it as well as some well known UI complilations that I forget the names of.

Edit: Reread your post a bit closer - its not addons - its the StaticPopup_Hide("PARTY_INVITE") interfering with the AcceptGroup().

StaticPopup_Hide("PARTY_INVITE") declines the invite.

You need AcceptGroup() and then a delay and then the StaticPopup_Hide("PARTY_INVITE").

Mercurio
10-22-2010, 09:53 AM
That seemed to be the issue, Jafula, thanks!

I took the StaticPopup_Hide("PARTY_INVITE") and put it into another macro and the accept macro works fine.

It is odd that that macro worked just fine until 4.0.1 and it is a bit of a bummer to have to hit two keys to do what only required one before, but I'm happy for a solution to something I use 12 times a day :)

BTW, there isn't any way to add a delay within a macro so I could keep it to one key, is there?

Noids
10-22-2010, 11:29 AM
Nah delays are a no go area. You can achieve them with third party hardware/software but they are outside of the ToS

You could use Jamba to do the party invite thing for you though or simply have your toons in a jamba team with auto acccept group invite from team selected. This is how I get away with a one key invite/accept buttotn.

Ughmahedhurtz
10-22-2010, 11:39 AM
You can try

/in 2 /run StaticPopup_Hide("PARTY_INVITE")

or some variant of that. I know it works for chat and a few other minor things. Never tried it out of combat on other things.

Sam DeathWalker
10-22-2010, 12:32 PM
So delays out of combat are not against the TOS?

Ughmahedhurtz
10-22-2010, 01:35 PM
Using the "/in" command is obviously OK as they provide the command for your use. I'd be very wary of extrapolating that to encompass any other delay mechanisms.

Mercurio
10-22-2010, 02:05 PM
Well... huh, more confusion.

Here's my latest macro:

/run AcceptGroup();ConfirmSummon();AcceptQuest(); AcceptTrade();RetrieveCorpse();RepopMe();
/click LFDRoleCheckPopupAcceptButton;
/click LFDDungeonReadyDialogEnterDungeonButton;
/in 1 /run StaticPopup_Hide("PARTY_INVITE");

I invited this toon, clicked the macro, and it worked like a charm! I thought great, problem solved, right? :)

Then I left party and tried it again, just to make sure.... insta-decline - the popup didn't even show up. :mad:

After trying this multiple times, when I log into the game the first time it works great, but all other times no matter who invites him until I relog my toon auto-declines. Good grief, I didn't figure an accept macro could be so complex.

shadewalker
10-22-2010, 02:53 PM
any chance you would need to show the staticpopup again before you could receive a new invite? /in 2 /run StaticPopup_Show("PARTY_INVITE"); I'm just guessing here and I'm not at my computer to try it out.

Jafula
10-22-2010, 03:00 PM
I think you can replace both AcceptGroup() and StaticPopup_Hide("PARTY_INVITE") with

/click StaticPopup1Button1

Not tested this, so I don't know if it works, but basically it clicks the first button on a dialog, so it should work for other dialogs.

Ughmahedhurtz
10-22-2010, 03:09 PM
After trying this multiple times, when I log into the game the first time it works great, but all other times no matter who invites him until I relog my toon auto-declines. Good grief, I didn't figure an accept macro could be so complex.
Sounds like you stumbled on a known UI bug. Now that you mention the failure conditions, I remember this happening with a group-invite macro where I just hid the dialog instead of clicking the button. Jamba's code works great so I disabled my macro and let it handle the invites. See if Jafula's suggestion fixes it.

Mercurio
10-23-2010, 01:36 AM
Sweet! Yep, that fixed it. All the accept stuff back in one button again :D

You guys are great.