Log in

View Full Version : Jamba causing "Interface action failed because of an AddOn" (Fixed)



nasaRed
07-07-2009, 04:29 AM
Notice this morning that Jamba (which was the only addOn I had so far installted (cleaning things up)) was causing "Interface action failed because of an AddOn" whenever I entered combat for the first time. So did a trace on this (using taint.log), which took me to ...

JambaCore.lua, line #698


ClearOverrideBindings( self.keyBindingFrame )

I changed this (after some Googling (seems patch 3.1 is responsible)) to ...


if not InCombatLockdown() then
ClearOverrideBindings( self.keyBindingFrame )
end

... and am no longer getting the error message.

(I'm fairly new to AddOn code though so use at own risk!)

Otlecs
07-08-2009, 04:49 AM
Thanks for the tip. I've often wondered what caused that error :)

I've applied your patch, but I was wondering if the other keybinding updates would also cause it? I was thinking of just having the function return immediately if in combat lockdown.

Jafula
07-08-2009, 05:14 AM
I'll put this fix into the next version of Jamba...

Multibocks
07-08-2009, 09:10 AM
so what does "ClearOverrideBindings( self.keyBindingFrame )" do that made interface fail?

Jafula
07-14-2009, 05:33 AM
so what does "ClearOverrideBindings( self.keyBindingFrame )" do that made interface fail?No idea; but other addons seem to have had this problem as well. I'm guessing that something changed in WoW (!) and the UPDATE BINDINGS event now gets called when you enter combat. Jamba-0.4f has been released with the above fix.

Multibocks
07-16-2009, 05:50 PM
omg omg must update!

edit: is updating jamba as simple as DL and copy/paste to addons? Will I lose anything?

Jafula
07-16-2009, 08:30 PM
Copy and paste will work. You should not lose anything.

Multibocks
07-16-2009, 08:52 PM
thanks your mod is awesome!